Merge v4-beta into v4 (2026-06-03)#178
Closed
xnacly wants to merge 2 commits into
Closed
Conversation
Add a `Setup MSVC Dev Cmd` step (a thin wrapper around `ilammy/msvc-dev-cmd` via the shared `setup-msvc-dev-cmd` action) to the prebuild job's step list on both reusable workflows: - node-matrix.yaml - node-matrix-pnpm.yaml Gated by `if: runner.os == 'Windows'`, so it is a no-op on Linux and macOS runners. Background: the runenv-python-3 repo's freesasa addition (PR #88) exposed that the prebuild matrix on Windows ships VS 2022 Build Tools but never activates them in the job shell. setuptools' distutils therefore fails to find `cl.exe` when `pip wheel` compiles a C extension from sdist, even though the headers and linker libs are on disk. Running the vcvars activation here means every downstream consumer of these reusable workflows gets a ready-to-build Windows env without having to roll their own activation (the runenv-python-3 PR initially did this in the builder; that code is now reverted in favour of this). The action also exports `DISTUTILS_USE_SDK=1`, which tells setuptools' MSVC compiler shim to skip its own VS lookup and trust the env vars already in scope (`INCLUDE` / `LIB` / `LIBPATH` / `PATH`). `arch` is mapped from the matrix's `amd64` / `arm64` values to vcvarsall's expected `amd64` / `arm64` args. Pattern mirrors the existing usage in milaboratory/pframes-rs (`.github/actions/setup-agent/action.yml`).
…node-matrix MILAB-6205: activate vcvars on Windows runners in node-matrix workflows
xnacly
added a commit
to platforma-open/runenv-python-3
that referenced
this pull request
Jun 3, 2026
milaboratory/github-ci#177 added a `Setup MSVC Dev Cmd` step to the node-matrix reusable workflows and was merged to v4-beta. The v4-beta -> v4 promotion (milaboratory/github-ci#178) is still open, so a build referencing `@v4` still hits the old workflow without MSVC activation. Per the team's convention (branch from v4-beta, experiment in v4-beta, validate downstream against v4-beta, then merge v4-beta to v4 and revert downstream pin), switch the reusable workflow reference to `@v4-beta` for the duration of this PR. Will be reverted to `@v4` once #178 merges. `context/init@v4` reference is left untouched, the action is unchanged on v4 (only the reusable workflow YAML was modified).
DenKoren
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fast-forward merge of v4-beta into v4. Includes PR #177 (Setup MSVC Dev Cmd step on Windows runners in node-matrix workflows).
Automated branch created by 0-merge-beta.yaml; the PR step in that workflow failed with "Resource not accessible by integration" so opening manually.
Greptile Summary
This PR fast-forwards
v4-betaintov4, bringing in PR #177 which adds a "Setup MSVC Dev Cmd" step to bothnode-matrix.yamlandnode-matrix-pnpm.yaml. The step activates the MSVC developer environment on Windows runners so that subsequent native C/C++ compilation steps (e.g.pip wheelagainst a setuptools sdist) can locatecl.exeand the SDK headers.Setup MSVC Dev Cmdstep to both node-matrix workflow files, guarded byif: runner.os == 'Windows', using the repo-internalsetup-msvc-dev-cmdaction (which in turn pinsilammy/msvc-dev-cmdto a specific commit hash).archinput is derived frommatrix.arch:arm64maps toarm64and everything else falls back toamd64, which correctly covers theamd64/arm64values used in the default matrix definition.ccacheconfiguration and Node.js environment setup, ensuring the MSVC toolchain is available for all native build steps that follow.Confidence Score: 5/5
The change is a focused, additive Windows-only step with a clear conditional guard, no impact on non-Windows runners, and no modifications to existing logic.
Both workflows receive identical, well-scoped additions. The underlying action pins ilammy/msvc-dev-cmd to a specific commit hash, the arch mapping covers all matrix values actually in use (amd64 and arm64), and placement before ccache/node preparation is correct. No existing steps are modified.
No files require special attention.
Important Files Changed
Sequence Diagram
sequenceDiagram participant Runner as Windows Runner participant MSVC as setup-msvc-dev-cmd@v4 participant ilammy as ilammy/msvc-dev-cmd (pinned) participant ccache as Configure ccache participant node as Node / pnpm prepare participant build as Native C/C++ build steps Runner->>MSVC: "if runner.os == 'Windows'" MSVC->>ilammy: "arch = (matrix.arch == 'arm64' ? 'arm64' : 'amd64')" ilammy-->>Runner: vcvarsall.bat sourced (cl.exe, SDK headers on PATH) Runner->>ccache: Configure ccache (if enabled) Runner->>node: Prepare Node environment Runner->>build: pip wheel / native extensions (cl.exe available)Reviews (1): Last reviewed commit: "Merge pull request #177 from milaborator..." | Re-trigger Greptile